fix getSysConn to work with TLS connections#918
Merged
Conversation
cinchurge
reviewed
Apr 30, 2024
DheerendraRathor
force-pushed
the
dheerendra/syscall.fix
branch
from
8d7c128 to
e32802d
Compare
DheerendraRathor
force-pushed
the
dheerendra/syscall.fix
branch
from
e32802d to
816a8d8
Compare
Collaborator
|
can you rebase off of #919 and push again? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tls.Connby default doesn't implementsyscall.Connand hence tchannel emitsonnection does not implement SyscallConn.log a lot.Since go 1.18,
tls.Connexposes methodNetConn()to expose raw underlying TCP connection. This is used for getting thesyscall.Conn.