Skip to content

Export altitudeToFovy & fovyToAltitude #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

Export altitudeToFovy & fovyToAltitude #244

merged 1 commit into from
Jul 19, 2021

Conversation

felixpalmer
Copy link
Collaborator

Required by deck.gl: visgl/deck.gl#5930 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.672% when pulling f5cc902 on felix/export-altitude-to-fov into 31747c7 on master.

ibgreen
ibgreen approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have docs that cover utils?

@felixpalmer
Copy link
Collaborator Author

Do we have docs that cover utils?

Yes, and they were update in the last PR. I just forgot to export the functions: https://github.com/uber-web/math.gl/pull/240/files#diff-29a903238434c314d09e48334767941aa391f67640656683096783f5d6a3c933R167

@felixpalmer felixpalmer merged commit 7214090 into master Jul 19, 2021
@felixpalmer felixpalmer deleted the felix/export-altitude-to-fov branch July 19, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @ibgreen