Swap expected and got fields #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbbit
approved these changes
May 8, 2023
Contributor
rabbbit
left a comment
rabbbit
left a comment
There was a problem hiding this comment.
do we actually have a recommendation somewhere on ordering the fields within the tests struct?
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 50 50
Lines 3242 3242
=======================================
Hits 3180 3180
Misses 53 53
Partials 9 9 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
May 8, 2023
Contributor
sywhang
left a comment
sywhang
left a comment
There was a problem hiding this comment.
Thanks @JacobOaks .
@rabbbit we don't - this fix has to do with the ordering of parameters passed to assert.Equal in line 58.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small nit from #1281 - I think the expected and got fields of the test case structs are flipped.