Skip to content

Conversation

@cardil
Copy link
Contributor

@cardil cardil commented Apr 22, 2022

Fixes #1085

Changes

  • 🐛 Tests pass regardless of codebase directory

@cardil cardil changed the title :bugTests pass regardless of codebase directory 🐛 Tests pass regardless of codebase directory Apr 22, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 22, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1087 (4a193bf) into master (d38507c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1087   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          49       49           
  Lines        2137     2137           
=======================================
  Hits         2101     2101           
  Misses         28       28           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38507c...4a193bf. Read the comment docs.

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the contribution

@sywhang sywhang merged commit 75dacb4 into uber-go:master Apr 22, 2022
@cardil cardil deleted the bugfix/dont-rely-on-codebase-path branch April 22, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Tests should pass regardless of codebase directory

3 participants