Add configuration file for default values to populate e.g. status choices for different core applications #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claire-peters
commented
Jul 31, 2023
| 'No', | ||
| 'Attribute Expanded Text' | ||
| ), | ||
| 'statuschoices': ( |
There was a problem hiding this comment.
Was considering adding comments to this file that indicate which default options are required for Coldfront to function - e.g., the "Active" status choice is so ubiquitous in the codebase that removing it as a default would require a lot of changes.
claire-peters
commented
Jul 31, 2023
| 'Float', | ||
| 'Int', | ||
| 'Text', | ||
| 'Yes/No', |
There was a problem hiding this comment.
Just a side note, but I've been curious about why yes/no is used here instead of booleans and where the "no" option is more appropriate than "yes/no".
claire-peters
commented
Jul 31, 2023
| 'projectuserstatuschoices': ( | ||
| 'Active', 'Pending - Add', 'Pending - Remove', 'Denied', 'Removed' | ||
| ), | ||
| # in utils.add_project_user_status_choices, projectuserstatuschoices are ['Active', 'Pending Remove', 'Denied', 'Removed']. |
There was a problem hiding this comment.
Left this question in the code. I didn't find "Pending Remove" in the code anywhere so I think I chose the correct options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally floated the idea of adding a new config file that would serve as a central reference list for all objects that are to be automatically added to the database in functions like add_allocation_defaults here. This PR is a follow-up on that. I included the default values for all apps with add_default commands in the config file, and then replaced the lists/tuples of those default values in the add_defaults commands with references to the config file.
There are a few ways I could see this config file being useful for other purposes, e.g., checking whether a given item is in the database in a given view.