Skip to content

fix: react dependency #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: react dependency #19

wants to merge 2 commits into from

Conversation

Zamiell
Copy link

@Zamiell Zamiell commented Jun 20, 2025

Change Summary

Since React 19.1.0 came out, this plugin gives warnings whenever it is installed. This PR attempts to fix this bug.

PR Checklist

@tharropoulos
Copy link

@Zamiell Have you tested it on both a React 18 and a React 19 app?

@Zamiell
Copy link
Author

Zamiell commented Jul 21, 2025

well we know it works fine on react 18 because it has been working fine for years.
as for react 19, yes, i have tested it on version 19.1.0 and it seems to work fine.
the UI still works as before and there are no errors in the javascript console.
all this PR will do is clean up the superfluous warnings on npm install.
as long as react follows semver (which they do) no minor version should break anything.

@tharropoulos
Copy link

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants