-
-
Notifications
You must be signed in to change notification settings - Fork 183
fix: add retry logic for downloads with configurable retries and backoff #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add retry logic for downloads with configurable retries and backoff #934
Conversation
#932) Bumps [cycjimmy/semantic-release-action](https://github.com/cycjimmy/semantic-release-action) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/cycjimmy/semantic-release-action/releases) - [Changelog](https://github.com/cycjimmy/semantic-release-action/blob/main/docs/CHANGELOG.md) - [Commits](cycjimmy/semantic-release-action@c4a2fa8...16ca923) --- updated-dependencies: - dependency-name: cycjimmy/semantic-release-action dependency-version: 4.2.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…933) Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me, just some minor things.
Also changed the base branch to merge into beta
for some extra testing before release.
packages/mongodb-memory-server-core/src/util/MongoBinaryDownload.ts
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## beta #934 +/- ##
==========================================
- Coverage 90.85% 89.62% -1.24%
==========================================
Files 15 15
Lines 2035 2072 +37
Branches 513 513
==========================================
+ Hits 1849 1857 +8
- Misses 175 215 +40
+ Partials 11 0 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
🎉 This PR is included in version 10.2.0-beta.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 10.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
fix #929