Skip to content

fix: add retry logic for downloads with configurable retries and backoff #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2025

Conversation

firefoxNX
Copy link
Contributor

fix #929

dependabot bot and others added 3 commits July 8, 2025 08:49
#932)

Bumps [cycjimmy/semantic-release-action](https://github.com/cycjimmy/semantic-release-action) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/cycjimmy/semantic-release-action/releases)
- [Changelog](https://github.com/cycjimmy/semantic-release-action/blob/main/docs/CHANGELOG.md)
- [Commits](cycjimmy/semantic-release-action@c4a2fa8...16ca923)

---
updated-dependencies:
- dependency-name: cycjimmy/semantic-release-action
  dependency-version: 4.2.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…933)

Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.12
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@firefoxNX firefoxNX requested review from nodkz and hasezoey as code owners July 13, 2025 18:54
@hasezoey hasezoey changed the base branch from master to beta July 14, 2025 11:41
Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, just some minor things.

Also changed the base branch to merge into beta for some extra testing before release.

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

❌ Patch coverage is 4.54545% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.62%. Comparing base (9430907) to head (b90e086).
⚠️ Report is 42 commits behind head on beta.

Files with missing lines Patch % Lines
...memory-server-core/src/util/MongoBinaryDownload.ts 3.07% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #934      +/-   ##
==========================================
- Coverage   90.85%   89.62%   -1.24%     
==========================================
  Files          15       15              
  Lines        2035     2072      +37     
  Branches      513      513              
==========================================
+ Hits         1849     1857       +8     
- Misses        175      215      +40     
+ Partials       11        0      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hasezoey hasezoey merged commit c738253 into typegoose:beta Jul 14, 2025
7 of 9 checks passed
Copy link

Copy link

github-actions bot commented Aug 2, 2025

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement released on @beta released Pull Request released | Issue is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoBinaryDownload stalls on Jenkins – add retry logic with exponential backoff
2 participants