Skip to content

Conversation

@RemyRylan
Copy link

@RemyRylan RemyRylan commented May 8, 2018

So sorry I was actually incorrect with my pull request earlier. Sincere apologies, especially since you already cut a release.

I'm sorry I missed it. I based my previous PR off a local change I made to turndown, but I didn't notice in my turndown tests I was calling turndown as a function with two parameters and that worked for me...but I didn't catch that you're actually using it as constructor, where the options actually need to be supplied to the constructor.

I promise it's correct this time!

@RemyRylan
Copy link
Author

RemyRylan commented May 8, 2018

Updating tests right now. Pushing up in a few minutes.

Edit, this is actually a lot of work -- and I forked Turndown to get this all working. Update coming soon.

@RemyRylan
Copy link
Author

All right! Tests are passing now. This was a lot to figure out, I'd like to do additional PRs in the to make testing easier and faster.

One thing to note is that I forked turndown so we can get correct syntax highlighting for fenced code blocks right now. I'll be following my PR there closely and when it gets merged (or some variant of it) I will send another PR here to switch back to using the unforked turndown if necessary...In the mean time I'll keep my fork up to date with the latest dependencies and such and won't be changing the API at all.

This is the repo if you're curious about commit history:
https://github.com/remyrylan/turndown/tree/flexible-code-classnames

npm package published here:
https://www.npmjs.com/package/@forked/turndown

As a side note:
I'm going to be using your plugin (either directly or a fork of it) for a huge number of packages (50+) that I'm in the process of releasing over the next several days, they've all been in development for a long time as part of a larger project. So with that in mind, I definitely have plenty of interest in helping out and doing as much as I can to contribute here.

@tgreyuk tgreyuk merged commit dc8e3b9 into typedoc2md:master May 9, 2018
@tgreyuk
Copy link
Member

tgreyuk commented May 9, 2018

Thanks for the PR. Happy to push as many releases as you need - it is good to get some collaboration going and any ideas on code improvements are welcome. It would be nice to switch back to un-forked turndown at some stage but we can keep an eye on that.

@RemyRylan
Copy link
Author

@tgreyjs You are the man! Thank you so much! Will definitely continue to send PRs and help maintain the great work you've done. Very much appreciated.

@RemyRylan RemyRylan deleted the patch-1 branch May 9, 2018 13:17
Vinnl added a commit to Vinnl/typedoc-plugin-markdown that referenced this pull request Aug 29, 2019
apolakipso pushed a commit to apolakipso/typedoc-plugin-markdown that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants