Fix compatibility with pytest 7.2#106
Merged
sobolevn merged 1 commit intotypeddjango:masterfrom Oct 26, 2022
The-Compiler:pytest72
Merged
Fix compatibility with pytest 7.2#106sobolevn merged 1 commit intotypeddjango:masterfrom The-Compiler:pytest72
sobolevn merged 1 commit intotypeddjango:masterfrom
The-Compiler:pytest72
Conversation
sobolevn
reviewed
Oct 26, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thank you! Can you please run isort to fix imports? (or do it manually)?
With pytest 7.2, the remaining parts of the "py.path" library got vendored, to get rid of the dependency: pytest-dev/pytest#10396 However, this breaks due to pytest_mypy_plugins importing private API: File ".../pytest_mypy_plugins/collect.py", line 13, in <module> from py._path.local import LocalPath ModuleNotFoundError: No module named 'py._path'; 'py' is not a package Use py.path.local instead (the public name of the same type), which is part of the shim included in pytest.
Contributor
Author
|
just did so! Looks like you need to kick the CI again. |
sobolevn
approved these changes
Oct 26, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thanks again! Related: typeddjango/django-stubs#1203
Member
|
I will make a new release today! |
griels
pushed a commit
to griels/pytest-mypy-plugins
that referenced
this pull request
Dec 19, 2024
With pytest 7.2, the remaining parts of the "py.path" library got vendored, to get rid of the dependency: pytest-dev/pytest#10396 However, this breaks due to pytest_mypy_plugins importing private API: File ".../pytest_mypy_plugins/collect.py", line 13, in <module> from py._path.local import LocalPath ModuleNotFoundError: No module named 'py._path'; 'py' is not a package Use py.path.local instead (the public name of the same type), which is part of the shim included in pytest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With pytest 7.2, the remaining parts of the "py.path" library got vendored, to get rid of the dependency: pytest-dev/pytest#10396
However, this breaks due to pytest_mypy_plugins importing private API:
Use py.path.local instead (the public name of the same type), which is part of the shim included in pytest.