Cast meta types to Type base type so that subs is compatible #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
approved these changes
May 15, 2020
|
it's a bit awkward that the current impl leads to MetaTypes having to be treated as Types sometimes - shouldn't they just be types? |
dmitrii-ubskii
pushed a commit
that referenced
this pull request
Aug 25, 2023
## What is the goal of this PR? To fix a bug that caused queries with more than 50 results to fail. This case was not correctly covered with a regression test and that has now been fixed. ## What are the changes implemented in this PR? - Added a test for queries with a size larger than 50 in order to trigger results batching. - Fixed a mismatch between batch options and batch size.
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-driver
that referenced
this pull request
Aug 31, 2023
Update to use tagged protocol for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
fix #98
To fix an issue where getting meta types via concept API causes a cast error. The
MetaTypeclass should be treated as aTypeso that it is compatible with regular type instances. This should prevents calls likesubson the meta type from incorrectly casting their subs to aMetaType.What are the changes implemented in this PR?
MetaTypes are treated likeTypefor the purposes of casting.