Retrieve Explanations Sequentially #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingsilverfin
requested review from
haikalpribadi and
marco-scoppetta
as code owners
haikalpribadi
approved these changes
Nov 1, 2019
dmitrii-ubskii
pushed a commit
that referenced
this pull request
Aug 25, 2023
* bump license date to 2019 * bump grakn deps manually * remove external runner for grakn in test-integration, relying only on initialisation from within integration test
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-driver
that referenced
this pull request
Aug 31, 2023
## What is the goal of this PR? Fix CI build by allowing certain actions (`npm pack`, `npm publish`) to be executed non-remotely ## What are the changes implemented in this PR? Starting from `0.27`, `bazel` automatically picks us `remote` strategy if it's available for action (see bazelbuild/bazel#7480 for details). However, setting `--spawn_strategy` explicitly prohibits `bazel` from using _any_ other strategy (such as `local`) — which is needed for executing `npm pack`/`npm publish` in `assemble_npm` and `deploy_npm`, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Matching protocol changes in typedb/typedb-protocol#20, we now iteratively retrieve layers of the
Explanationtree of aConceptMapanswer.ConceptMap.explanation()does a round trip to the Grakn server and retrieves a list ofConceptMapthat explain how the given concept map was obtained. We also restrictExplanationto only be obtainable fromConceptMap, given that we have not implementedExplanationon delete, count, etc. queries.What are the changes implemented in this PR?
ConceptMapcontains aqueryPattern-- this is empty if reasoner is not triggered, and the new methodhasExplanation()will returnfalsehasExplanation()is true, it is possible to send the ConceptMap back to the server viaTransactionto obtain anExplanationobjectExplanationobject only contains a list ofConceptMap