tsc ignoring file change & hanging build when watching

[billheaton-q2]

tsc is ignoring a .ts file change, and because of that, ember-cli is hanging the build.

• typescript v2.8.3
• ember-cli-typescript v1.3.0"
• node.js v8.11.1
• ember-cli v3.2.1

⚡ ember build -w

Build successful (19446ms)

Slowest Nodes (totalTime => 5% )              | Total (avg)         
----------------------------------------------+---------------------
Babel (47)                                    | 8687ms (184 ms)     
EslintValidationFilter (7)                    | 3716ms (530 ms)     
Concat (13)                                   | 2497ms (192 ms)     

file changed controllers/login.ts
file changed controllers/login.ts

Could not reproduce using the dummy app in ember-cli-typescript.
I tried using the default install of the tsconfig.json proivided by ember-cli-typescript.
I also tried adding ember-decorators to the dummy app as our app uses decorators.

Not sure what the issue is with our app setup. We use in-repro addons, and a bunch of dependencies. The apps have mostly .js still as we are moving toward more TS use. Changes to .js files work fine.

Using DEBUG=\* ember b -w ....

  ember-cli-typescript:tsc:trace DirectoryWatcher:: Triggered with /pathtoapp/app/controllers/login.ts:: WatchInfo: /pathtoapp 1 +55s
  ember-cli-typescript:tsc:trace Elapsed:: 102ms DirectoryWatcher:: Triggered with /pathtoapp/app/controllers/login.ts:: WatchInfo: /pathtoapp 1 +102ms
  ember-cli-typescript:compiler-state tscDidStart | broccoli: 0 active nodes | tsc: building (0 errors) +33s
  ember-cli-typescript:tsc:trace DirectoryWatcher:: Triggered with /pathtoapp/app/controllers/login.ts:: WatchInfo: /pathtoapp 1 +2ms
  ember-cli-typescript:tsc:trace Elapsed:: 57ms DirectoryWatcher:: Triggered with /pathtoapp/app/controllers/login.ts:: WatchInfo: /pathtoapp 1 +57ms
  ember-cli-typescript:compiler-state tscDidStart | broccoli: 0 active nodes | tsc: building (0 errors) +59ms
file changed controllers/login.ts
  broccoli-sane-watcher scheduleBuild: /pathtoapp/app/controllers/login.ts +30s
file changed controllers/login.ts
  broccoli-sane-watcher debounce scheduleBuild: /pathtoapp/app/controllers/login.ts +1ms
  broccoli-sane-watcher build: /pathtoapp/app/controllers/login.ts +100ms
  broccoli-sane-watcher { type: 'rebuild', reason: 'watcher', primaryFile: '/pathtoapp/app/controllers/login.ts', changedFiles: [ '/pathtoapp/app/controllers/login.ts', '/pathtoapp/app/controllers/login.ts' ] } +0ms
 ...

  async-promise-queue: started, with concurrency=1 +0ms
  broccoli-persistent-filter:Babel > [Babel: ember-cli-app-version] [TreeMerger (addon)#4153 -> broccoli-persistent-filter:Babel > [Babel: ember-cli-app-version]: Babel: ember-cli-app-version#4213 -> applyPatches#4220] applyPatches duration: 0.13 ms {"mkdir":0,"rmdir":0,"unlink":0,"change":0,"create":0,"other":0,"processed":0,"linked":0,"processString":0,"processStringTime":0,"persistentCacheHit":0,"persistentCachePrime":0} +0ms
  ember-cli-typescript:compiler-state broccoliDidStart | broccoli: 1 active nodes | tsc: building (0 errors) +172ms

The work around for us is to use : ember install ember-cli-typescript@v1.3.0-beta.4

I'll try to post a repo once I can make one without sharing our entire app(s)

[pixelhandler]

Oops, I meant to post this using my normal github user :(

Please reply at @pixelhandler instead of the user I posted with, thx.

The changes in https://github.com/typed-ember/ember-cli-typescript/pull/196/files are what resulted in our app not watching and completing a build for changes to .ts files.

Not sure yet what is different about the way our apps are setup compared with others using e-c-ts addon. We do use in-repo addons and app.import from node_modules in ember-cli-build.js

[Bouke]

With ember-cli-typescript 1.3.1 I'm experiencing the same issues. Reverting back to 1.3.0-beta4 seems to be a workaround for me as well.

[dfreeman]

@Bouke can you share more details of your setup, or (better yet) a sample repo that reproduces the issue? Up to now we haven't been able to make any progress on this because no one's been able to see the problem outside of @pixelhandler's app, but having a second data point could go a long way toward figuring out the issue 🙂

[gossi]

There you go, I do have a repo to showcase this problem: https://github.com/gossi/unicycle-freestyle-tools

Clone and then yarn install (maybe yarn upgrade afterwards) and yarn start to give it a go. Make a change in src/ui/components/wurst/component.ts and then the serving stops. You can keep continuing seeing changes to files you make on your terminal but that's it.

[dfreeman]

@gossi In that repo it looks like you're missing src in your include array in tsconfig.json. If I add that, rebuilds work for me locally.

[gossi]

@dfreeman YAS! That's it. Maybe @pixelhandler there is something similar about your project?

[pixelhandler]

@gossi our ember app is in a folder named app instead of the name of the project, e.g. app-name as indicated in the package.json. For example, when I create an application using ember-cli... ember new app-name that folder app-name was renamed to app. However we do include the actual app directory in our tsconfig.json file.

Our directories are setup like so:

repo/
  app/ (front end)
    app/ (ember app)
  host/ (server app)

I was curious if the path app/app may be an issue so renamed app/app to app/other-name but I still had the issue.

[chriskrycho]

@pixelhandler what does your tsconfig.json look like?

[pixelhandler]

@chriskrycho here is one, we have two apps that use the same config and directory structure:

{
  "compilerOptions": {
    "target": "es2017",
    "allowJs": true,
    "moduleResolution": "node",
    "allowSyntheticDefaultImports": true,
    "noImplicitAny": false,
    "noImplicitThis": true,
    "alwaysStrict": false,
    "strictNullChecks": false,
    "strictPropertyInitialization": false,
    "noFallthroughCasesInSwitch": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "noImplicitReturns": false,
    "noEmitOnError": false,
    "noEmit": true,
    "inlineSourceMap": true,
    "inlineSources": true,
    "baseUrl": ".",
    "module": "es6",
    "experimentalDecorators": true,
    "paths": {
      "back-office/tests/*": [
        "tests/*"
      ],
      "back-office/mirage/*": [
        "mirage/*"
      ],
      "back-office/*": [
        "app/*",
      ],
      "*": [
        "types/*"
      ]
    }
  },
  "include": [
    "app",
    "tests",
    "types",
    "mirage"
  ]
}

Since the app name is back-office the modules are registered as so, however in the file system the modules live under app/app.

[chriskrycho]

I think your paths mappings are slightly off, then. If I'm understanding correctly, they should be like this:

"back-office/*": [
  "app/app/*"
]

[pixelhandler]

@chriskrycho the tsconfig.json is located in rpeo/app/tsconfig.json, as a sibling to ember's app directory.

repo/
  app/ (front end, root of ember-cli generated application)
    app/ (ember app code)
    tsconfig.json
  host/ (server app)

is there a reason that the tsconfig.json would need to reference it's parent directory?

[chriskrycho]

Ah, I see. No, that should be fine; I misread before.

🤔