add Empty to T interface and correct Empty for GeometryCollection #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ah, this feels like the proper way to implement #155. |
twpayne
reviewed
May 18, 2020
Owner
twpayne
left a comment
twpayne
left a comment
There was a problem hiding this comment.
Looks great! Just one minor nit about where to put the tests. Once those are addressed I'll merge it :)
* Add Empty() to the T interface, which is defined on all geom.T types. * Add interface assertions for all the types, makes unimplemented interface errors easier to read at compile time. * In PostGIS (at least), its possible for a GeometryCollection to have multiple Empty elements and still be considered empty, e.g. `GEOMETRYCOLLECTION(POINT EMPTY, LINESTRING EMPTY)`. This check changes the Empty check such that GeometryCollection's Empty() also checks for these cases.
otan
changed the title
Owner
|
Thanks for this great contribution :) I've tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interface errors easier to read at compile time.
multiple Empty elements and still be considered empty, e.g.
GEOMETRYCOLLECTION(POINT EMPTY, LINESTRING EMPTY). This check changesthe Empty check such that GeometryCollection's Empty() also checks for
these cases.