feat(model, cache): add missing fields to Member #2476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeonzip
changed the title
github-actions
bot
added
c-cache
zeonzip
changed the title
HTGAzureX1212
requested changes
Nov 4, 2025
|
|
||
| impl From<Member> for CachedMember { | ||
| fn from(member: Member) -> Self { | ||
| #[allow(unused_variables)] |
Member
There was a problem hiding this comment.
We should also cache the avatar decoration data and banner instead of allowing unused_variables here.
Erk-
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fields to the [
Member] struct which was missing in model.https://discord.com/developers/docs/resources/guild#guild-member-object
permissions (ignored), banner and avatar_decoration_data was missing, and in this PR it is added.
(permissions was ignored because we already have it present in PartialMember with interactions, this is the only case where permissions would deserialize to Some)