Skip to content

Conversation

@zeonzip
Copy link
Contributor

@zeonzip zeonzip commented Oct 15, 2025

Adds support for changelog entry gradient roles and guild tags.

Closes #2465

@github-actions github-actions bot added c-cache Affects the cache crate c-model Affects the model crate c-standby Affects the standby crate t-feature Addition of a new feature labels Oct 15, 2025
@zeonzip zeonzip changed the title feat(model): support for role colors and primary guilds feat(model)!: support for role colors and primary guilds Oct 17, 2025
@github-actions github-actions bot added the m-breaking change Breaks the public API. label Oct 17, 2025
@zeonzip
Copy link
Contributor Author

zeonzip commented Oct 17, 2025

Breaking change: bumps event threshold, which causes Ready to fall back below the new bumped event threshold, therefore making it not boxed anymore in this version. library users will have to work with Ready instead of Box<Ready>

Copy link
Member

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will aporove when clippy and rustfmt have been made happy :)

@HTGAzureX1212
Copy link
Member

The spelling job is failing but is unrelated to code changed.

Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking a while to get around to this pr.

A few things, but overall it looks quite good.

@zeonzip zeonzip requested a review from Erk- October 31, 2025 16:14
@zeonzip zeonzip requested a review from HTGAzureX1212 November 1, 2025 20:07
@zeonzip
Copy link
Contributor Author

zeonzip commented Nov 1, 2025

Sorry, accidentally paged @HTGAzureX1212 for another review after approval 🤦

@Erk- Erk- merged commit 1f7c3d1 into twilight-rs:next Nov 2, 2025
9 checks passed
@Erk-
Copy link
Member

Erk- commented Nov 2, 2025

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-cache Affects the cache crate c-model Affects the model crate c-standby Affects the standby crate m-breaking change Breaks the public API. t-feature Addition of a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants