refactor/move-kernelfunc #462
Conversation
✅ Deploy Preview for tweag-jupyterwith ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Notice: #450 (comment), (I don't know why). Also, I think it is necessary to provide an additional option for poetryEnv, not only the problem of overalys, the most important thing is that pythonEnv can be passed from the outside. (we can simply add a group deps of jupyenv for other poetyEnv , then add it) |
| groups, | ||
| ignoreCollisions, | ||
| }: let | ||
| env = |
There was a problem hiding this comment.
we should move the env to the moduleType totally, and make sure the users are able to rescue the poetyEnv and pure python support. like that https://github.com/GTrunSec/jupyterWith/blob/dev/modules/types/poetry.nix#L136
| @@ -19,9 +21,78 @@ | |||
| }: let | |||
| args = {inherit self system lib config name kernelName requiredRuntimePackages;}; | |||
| kernelModule = import ./kernel.nix args; | |||
|
|
|||
| kernelFunc = { | |||
There was a problem hiding this comment.
could we only keep some necessary args in the KernelFunc? (simplify it again)
https://github.com/GTrunSec/jupyterWith/blob/dev/kernels/available/python/default.nix#L7
Extract
kernelFuncto modules/poetry.nix.