Fix: Removed duplicate calls to clean_xcode_tools and clean_code_editors#593
Merged
Fix: Removed duplicate calls to clean_xcode_tools and clean_code_editors#593
Conversation
in lib/clean/app_caches.sh clean_user_gui_application() was making calls to clean_xcode_tools and clean_code_editors. in lib/clean/dev.sh clean_xcode_tools and clean_code_editors was also being called, causing the duplication when executing the clean command. removed the calls from lib/clean/app_caches.sh clean_user_gui_application since these two calls are developer focused.
Owner
|
@jason-costello Thanks for the fix. I added a follow-up commit before merging to strengthen the regression test in tests/clean_app_caches.bats, so the PR now explicitly verifies that clean_user_gui_applications() no longer calls clean_xcode_tools or clean_code_editors while still covering the remaining application groups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #590