Alternative output format when printing the created fixup commits #177
Conversation
This was done sine they are not really helpful to the avarage user, and take up precious line space that will be used in later commits for better stuff :)
This is more readble by the avarage user, still usable in the git CLI when copy-pasting and saves us a metric ton of precious line space :)
Do note that if you used the absorb.fixupTargetAlwaysSHA option (or its cli equvalient), you will see the commit hash instead. I don't think its interesting enough to fix (maybe this is even the intended behaviour?) You decide!
| let drain = slog_term::FullFormat::new(decorator).build().fuse(); | ||
| let drain = slog_term::FullFormat::new(decorator) | ||
| // Don't write a timestamp, as requested in #126 | ||
| // I am currently running git absorb myself, I know what time it is :) |
There was a problem hiding this comment.
no self-explanatory comments please. anyone who wants to know why we did this can blame it
|
@arielf212 I notice that you haven't been active in this PR for a bit. |
blairconrad
left a comment
blairconrad
left a comment
There was a problem hiding this comment.
I don't want to take a PR away from someone, but it seems this one is stuck. I have an alternative implementation for the log-formatting which I think provides a better result, and I've applied it to a conflict-free branch. If there's interest, I can incorporate most of these changes and get a fix moving by the weekend.
| let drain = slog_term::FullFormat::new(decorator) | ||
| // Don't write a timestamp, as requested in #126 | ||
| // I am currently running git absorb myself, I know what time it is :) | ||
| .use_custom_timestamp(|_| Ok(())) |
There was a problem hiding this comment.
clever, but leaves an extra space at the beginning of each output line
|
sure, i'll take an alternate pr for this if you've got one |
3 participants
closes #126
Please read the commit messages, especially the last one: