Option to always split profession related bags #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I wanted to contribute and add an option to be able to automatically split bags if they are profession bags, for neatness. I'm always manually enabling bags to split off ones that are profession related between characters and profiles. I've made the relevant changes and tested it a few times. I've added the locale strings (hopefully in the correct place).
Note:
I've made the assumption that any bag from
that is ~= 0 is a profession type bag, not sure this is 100% safe.
Let me know if changes are needed.
Thanks for all the hard work over the years!