Skip to content

[MRG] Fixes #387 #403: proper serialization for learning shapelets#623

Merged
charavelg merged 2 commits intomainfrom
387-how-to-save-and-load-fitted-learningshapelets-model
Dec 16, 2025
Merged

[MRG] Fixes #387 #403: proper serialization for learning shapelets#623
charavelg merged 2 commits intomainfrom
387-how-to-save-and-load-fitted-learningshapelets-model

Conversation

@charavelg
Copy link
Copy Markdown
Contributor

Support json and pickle serialization for LearningShapelets

@charavelg charavelg linked an issue Dec 15, 2025 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (01f6992) to head (becb872).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   91.82%   91.85%   +0.03%     
==========================================
  Files          68       68              
  Lines        6178     6203      +25     
==========================================
+ Hits         5673     5698      +25     
  Misses        505      505              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charavelg charavelg linked an issue Dec 15, 2025 that may be closed by this pull request
@charavelg charavelg merged commit fae377a into main Dec 16, 2025
35 checks passed
@charavelg charavelg deleted the 387-how-to-save-and-load-fitted-learningshapelets-model branch December 16, 2025 13:06
charavelg added a commit that referenced this pull request Jan 12, 2026
* Update issue templates

* Refactor prediction logic in KNeighborsTimeSeries to use a shared function (#617)

Refactor prediction logic in KNeighborsTimeSeries to use a shared preprocessing function

---------

Co-authored-by: charavelg <guillaume.charavel@inria.fr>

* Update docs requirements

* Remove whitespaces

* Remove whitespaces

* Update docs requirements (#620)

* [WIP] Python 3.14 support (#602)

* [MRG] Fixes #387 #403: proper serialization for learning shapelets (#623)

* Fixes #387 #403: proper pickling of optimizer and n_shapelets_per_size hyper params

* Speed up codecov job

* Update docs requirements (#628)

* Reduce CI storage usage (#629)

Reduce CI storage usage not using cache and using torch cpu package which doesn't require the huge nvidia dependencies

---------

Co-authored-by: Toky RT <tokyrt.pro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LearningShapelets: impossible to pickle the model How to Save and Load fitted LearningShapelets model

1 participant