Fix: Change external-secrets api version #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmatviichuk
force-pushed
the
bump-external-secrets-api-version
branch
from
1ef8e75 to
bcdb152
Compare
|
It seems this might be cluster-dependent, we may not be able to merge this as-is. We may want to add an if statement checking the externalsecrets CRD version on the cluster for this like we do here: Thanks for the catch! |
dmatviichuk
force-pushed
the
bump-external-secrets-api-version
branch
from
bcdb152 to
9080ad9
Compare
dmatviichuk
force-pushed
the
bump-external-secrets-api-version
branch
from
d27fb14 to
501e7e5
Compare
|
@jjlgao it is fixed now and all checks are passed, please review |
jjlgao
approved these changes
Jun 13, 2025
|
Just a heads up, I'll wait until we have a few other changes before we release a new version. If it's urgent for you to pull and use this change, happy to do so earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "The Kubernetes API could not find version "v1beta1" of external-secrets.io/ExternalSecret for requested resource retool-dev/vault-external-secrets. Version "v1" of external-secrets.io/ExternalSecret is installed on the destination cluster."