Skip to content

Conversation

christinaexyou
Copy link
Contributor

This PR address #192 by moving viz methods from the explainers module to following files:

  • visualizations/visualization_results.py: abstract class for visualization methods
  • visualizations/factory.py: gets visualization according to explanation method/class
  • visualizations/shap.py
  • visualizations/lime.py
  • visualizations/pdp.py
  • visualizations/distance.py

@christinaexyou christinaexyou force-pushed the issue-192 branch 5 times, most recently from 4d3f128 to 0e95b69 Compare February 21, 2024 18:08
@christinaexyou christinaexyou force-pushed the issue-192 branch 4 times, most recently from 5e7a6fe to b42beca Compare February 28, 2024 21:35
@christinaexyou
Copy link
Contributor Author

changes made:

  • moved all viz methods to seperate module visualizations
  • updated tests to reflect change

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I just added a comment inline about type hints for plot.
Also, perhaps the whole factory could go into visualizations/__init__.py to simplify the import (i.e. from trustyai.visualizations import plot).

But I'm fine with merging without these.

@christinaexyou
Copy link
Contributor Author

changes made:

  • renamed visualizations/factory.py -> visualizations/__init__.py
  • refactored tests to reflect change

@ruivieira ruivieira merged commit e6ea26a into trustyai-explainability:main Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants