feat(crypto): optimize zksnark config #6371
Conversation
| if (isShieldedTransaction(trx.getInstance()) && !Args.getInstance() | ||
| .isFullNodeAllowShieldedTransactionArgs()) { | ||
| return true; | ||
| if (isShieldedTransaction(trx.getInstance()) && !chainBaseManager.getDynamicPropertiesStore() |
There was a problem hiding this comment.
So how can we support shielded transaction through config item committee.xxx ?
There was a problem hiding this comment.
To support shielded transactions, we need to turn on ALLOW_SHIELDED_TRANSACTION proposal. However, the corresponding code is commented out.
| @@ -24,11 +24,6 @@ private void init() { | |||
| public static void librustzcashInitZksnarkParams() { | |||
There was a problem hiding this comment.
Can this be optimized so that it is only initialized once in the JVM? Currently, a large number of unit tests repeatedly generate related files, causing insufficient space in the tmp folder.
There was a problem hiding this comment.
ok, I will fix it.
There was a problem hiding this comment.
private static final AtomicBoolean initialized = new AtomicBoolean(false);
If (initialized.compareAndSet(false, true)){
do InitZksnark
}There was a problem hiding this comment.
After optimization, the initZksnarkParams method is invoked only 6 times during tests, significantly fewer than before.
| @@ -1030,10 +1030,6 @@ public static void setParam(final Config config) { | |||
| config.hasPath(Constant.NODE_SHIELDED_TRANS_IN_PENDING_MAX_COUNTS) ? config | |||
| .getInt(Constant.NODE_SHIELDED_TRANS_IN_PENDING_MAX_COUNTS) : 10; | |||
|
|
|||
| if (PARAMETER.isWitness()) { | |||
| PARAMETER.fullNodeAllowShieldedTransactionArgs = true; | |||
There was a problem hiding this comment.
I think it should be removed. The witness can allow the shieldedTransactionApi freely.
Federico2014
force-pushed
the
fix/optimize_zksnark_config
branch
from
3a031e3 to
7676699
Compare
What does this PR do?
Close #6334