feat(jsonrpc): jsonrpc set error resolver #6369
Conversation
0xbigapple
changed the title
0xbigapple
changed the title
There was a problem hiding this comment.
Just modify JsonRpcInternalException itself?
Do not modify TronException.
There was a problem hiding this comment.
Just modify JsonRpcInternalException itself? Do not modify TronException.
Thank you for your suggestion. I have added a JsonRpcException as the parent class for JSON-RPC exceptions, which makes it easier to extend the data field for all JSON-RPC exceptions. d575241
|
Like |
|
|
||
| @Getter | ||
| public class JsonRpcException extends TronException { | ||
| private Object data = null; |
There was a problem hiding this comment.
why not define data's type as byte[] ?
There was a problem hiding this comment.
Object is more general than byte[], I think
There was a problem hiding this comment.
Yes, use the Object type because it is more flexible and can support various kinds of data.
What does this PR do?
Support setting of data field when jsonrpc return error， from #6330
Why are these changes required?
This PR has been tested by:
Follow up
Extra details