Skip to content

test(net): add message handler test cases #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 11, 2023

Conversation

jwrct
Copy link
Contributor

@jwrct jwrct commented Aug 31, 2023

What does this PR do?
add new test cases for message handler module

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #5459 (9d089e7) into release_v4.7.3 (fa8d8cf) will increase coverage by 0.27%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                 Coverage Diff                  @@
##             release_v4.7.3    #5459      +/-   ##
====================================================
+ Coverage             64.56%   64.83%   +0.27%     
- Complexity             9679     9722      +43     
====================================================
  Files                   867      867              
  Lines                 51725    51725              
  Branches               5755     5755              
====================================================
+ Hits                  33394    33538     +144     
+ Misses                15725    15560     -165     
- Partials               2606     2627      +21     

see 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jwrct jwrct requested review from 317787106 and xxo1shine September 1, 2023 02:05
@jwrct jwrct changed the title test(net): add message handler test test(net): add message handler test cases Sep 4, 2023
@halibobo1205 halibobo1205 mentioned this pull request Aug 29, 2023
5 tasks
@jwrct jwrct changed the base branch from develop to release_v4.7.3 September 12, 2023 06:30
import org.tron.protos.Protocol;


public class PbftMsgHandlerTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended to extend BaseTest.

@jwrct jwrct merged commit 419570c into tronprotocol:release_v4.7.3 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants