Skip to content

Conversation

raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Nov 27, 2024

Description

Waiting a short time for dynamic filters to arrive can be highly beneficial for some queries with selective joins

Additional context and related issues

#23945 caused regressions on some TPCDS queries due to splits generation getting faster and not allowing enough time for dynamic filters to arrive.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Iceberg
* Improve performance of queries with selective joins. ({issue}`24277`)

@raunaqmorarka
Copy link
Member Author

Screenshot 2024-11-27 at 6 48 37 PM Screenshot 2024-11-27 at 6 48 18 PM Screenshot 2024-11-27 at 6 48 11 PM Screenshot 2024-11-27 at 6 48 00 PM

Waiting a short time for dynamic filters to arrive can be
highly beneficial for some queries with selective joins
@sopel39
Copy link
Member

sopel39 commented Nov 27, 2024

Why not to make that automatic? ;)

@raunaqmorarka raunaqmorarka merged commit d614541 into trinodb:master Nov 27, 2024
45 checks passed
@raunaqmorarka raunaqmorarka deleted the ice-wait branch November 27, 2024 15:11
@github-actions github-actions bot added this to the 466 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants