STK: Cannot build as shared library on OSX

[jrood-nrel]

When building with STK enabled on OSX (Sierra) as a shared library using Clang v9.0.0-apple and GCC 7.3.0, I get this error:

Undefined symbols for architecture x86_64:
  "stk::handle_assert(char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from:
      sierra::MPI::AllReduce(ompi_communicator_t*, sierra::MPI::ReduceSet const&) in MPI.cpp.o
      sierra::MPI::(anonymous namespace)::ReduceCheck::copyout(void*&) const in MPI.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [packages/stk/stk_util/stk_util/parallel/libstk_util_parallel.12.13.dylib] Error 1
make[1]: *** [packages/stk/stk_util/stk_util/parallel/CMakeFiles/stk_util_parallel.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

When building as a static library on OSX, everything works fine. Also when building either shared or static with STK enabled on Linux works fine. I used Spack to investigate this, so I install with either trilinos+shared or trilinos~shared when testing this. The easiest way to see this I think would be to use spack install nalu-wind on OSX Sierra to see Trilinos fail with this error. (Update: I developed a workaround for this in Spack, so it won't build as a shared library on OSX)

@trilinos/stk

[tjfulle]

@jrood-nrel, I build stk with shared libraries on macOS, but I have to apply the attached patch
stk_diff.txt. One of the changes in the diff fixes a missing dependency in a CMakeLists.txt. I'm not sure why the build succeeds on Linux but fails on macOS (maybe having to do with differences in how each OS alphabetizes lower/upper case filenames that affects order of CMake processing?).

The other patch in the diff file is a kludge to bypass the missing stk::handle_assert. I tried to come up with a "real" fix, but gave up after some time.

[mhoemmen]

@alanw0

[mhoemmen]

@tjfulle We should file a ticket for STK w/ the patch -- I'm pretty sure they would be willing to apply it from their end.

[tjfulle]

@mhoemmen, you should look at the kludge before making that assertion 😂

[tjfulle]

@mhoemmen , but I have an idea of what needs to be fixed, I just haven't had the time

[mhoemmen]

@tjfulle Let's just file a ticket, give 'em the patch, and let them sort it out ;-)

I'm not sure what the rules are these days for applying STK patches to Trilinos. @trilinos/framework might have some idea about that.

[tjfulle]

Okay, can you email me a link where I can file a ticket?

[mhoemmen]

@tjfulle done; thanks!

[prwolfe]

stk patches should be applied in Sierra and migrated into Trillinos via the PR process. There is a PR waiting for a newer Seacas at the moment (see #2930 )

[khpierson]

@khpierson would like to know what the status is of this issue.

Thanks!
-Kendall

[jrood-nrel]

Is there any update on this? It would be quite convenient to be able to build with STK as shared libraries on Mac again.

[mhoemmen]

@alanw0

[alanw0]

@jrood-nrel to address the issue with stk::handle_assert not being found for stk_util_parallel, we have moved (a while back) the ReportHandler.hpp/cpp files into the stk_util_util library, which stk_util_parallel can depend on. (Previously they were located in the stk_util_environment library, which stk_util_parallel could not depend on without causing a circular dependency. It is possible that we also need to add 'DEPLIBS stk_util_util' into stk_util/parallel/CMakeLists.txt also. I will do that right away and get another update pushed into Trilinos and let you know when it is done. I'm also adding the DEPLIBS line to the unit_main library as requested above by @tjfulle. I'll add another comment here when they are in. Sorry for the delay, and for letting this issue fall through the cracks!