Skip to content

Conversation

@deep1401
Copy link
Member

image image image

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/transformerlab/routers/serverinfo.py 17.64% 14 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Member Author

@deep1401 deep1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we talk more on this and merge post-release?

@dadmobile
Copy link
Member

Maybe we talk more on this and merge post-release?

Yeah I think let's play around and revisit this after the release.

@josh-janes
Copy link
Contributor

I was thinking, do we even want an auto-updater in cloud mode? Generally with cloud apps developers want some control over which users are seeing which version of the app. When we do updates in cloud, they're generally rolling updates so we can roll out the new version to a certain % of the users, and roll back if we detect any errors early on. It might be hard to detect/troubleshoot issues in the code if we can't guarantee that a user is on a particular version of the app.

Or maybe I'm misunderstanding the intention/terminology here, are we planning on having our API running in the cloud, or will it always be a local thing?

@aliasaria
Copy link
Member

I'm worried that if an admin sets up Transformer lab on their team, then users shouldn't be able to update the code (they may have added custom code, or are tied to a specific version). Autoupdate only makes sense if it is a single user. So maybe we can just make the "update available" really loud instead of autoupdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants