feat: Support custom package root #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow tov-uv to recognize properly a custom package root if any, without enforcing to have pyproject.toml in the same directory of tox.ini Address issue tox-dev#220
for more information, see https://pre-commit.ci
gaborbernat
requested changes
Aug 4, 2025
| @@ -112,7 +113,14 @@ def _setup_env(self) -> None: # noqa: C901 | |||
| cmd.extend(("-p", self.env_version_spec())) | |||
|
|
|||
| show = self.options.verbosity > 2 # noqa: PLR2004 | |||
| outcome = self.execute(cmd, stdin=StdinSource.OFF, run_id="uv-sync", show=show) | |||
| cwd = self.package_root() | |||
There was a problem hiding this comment.
Should be root instead of cwd.
| @@ -310,6 +311,18 @@ def _py_info(self) -> PythonInfo: # pragma: win32 no cover | |||
| extra={}, | |||
| ) | |||
|
|
|||
| def package_root(self) -> Path: | |||
There was a problem hiding this comment.
This should be a cached property.
| try: | ||
| return self.core["package_root"] | ||
| except KeyError: | ||
| config = self.core["tox_root"] / "tox.ini" |
There was a problem hiding this comment.
This can be a lot more, than just ini, like toml and various other file sources we support.
| @@ -168,6 +168,9 @@ overwritten by the VIRTUALENV_SYSTEM_SITE_PACKAGES environment variable. This fl | |||
| We use `uv pip` to install packages into the virtual environment. The behavior of this can be configured via the | |||
| following options: | |||
|
|
|||
| tox-uv resolves your project location based on the `package_root` setting. If that option is not defined, it will fall | |||
There was a problem hiding this comment.
We don't really want to publicize setupdir, rather package_root is what we should only advertise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tov-uv to recognize properly a custom package root if any, without enforcing to have pyproject.toml in the same directory of tox.ini
Address issue #220