Conversation
Originally added to allow people to copy test for a specific TOML version (see: #134), but the "copy" command is now a better way to do it. The reason I'd like to remove it is that people keep modifying these generated files in PRs, which is the wrong way to do it. I also had some amount of trouble writing a good usage text explaining why this command is useful, which is often a good indication that it's not. So I don't see much point in retaining it? If someone really wants it, then it can be re-add I suppose. Or copy can be improved to suit the use case.
Contributor
|
Would you be willing to revisit this decision? I maintain a Rust implementation so we can run |
1 task
arp242
added a commit
that referenced
this pull request
Dec 18, 2025
Member
Author
|
Okay, I added it back. I'll release a new 2.1.0 once I fixed #181 (probably not today). |
Contributor
|
Thanks! I update off of commits, not releases, so I'm good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally added to allow people to copy test for a specific TOML version (see: #134), but the "copy" command is now a better way to do it.
The reason I'd like to remove it is that people keep modifying these generated files in PRs, which is the wrong way to do it. I also had some amount of trouble writing a good usage text explaining why this command is useful, which is often a good indication that it's not.
So I don't see much point in retaining it? If someone really wants it, then it can be re-add I suppose. Or copy can be improved to suit the use case.