Answer:2 #8
Closed
Answer:2 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalaforge
reviewed
Nov 25, 2022
| ); | ||
|
|
||
| constructor(private actions$: Actions) {} | ||
| } |
Owner
There was a problem hiding this comment.
this effect is not necessary. UserEffect and ActivityEffect can both listen to appAction.initApp.
tomalaforge
reviewed
Nov 25, 2022
| | async | ||
| " | ||
| > | ||
| "> |
Owner
There was a problem hiding this comment.
the goal is to avoid calling a function inside a template. The view object should be constructed inside the selector. Thus in the view, only property of that object will be rendered
tomalaforge
reviewed
Nov 25, 2022
| this.store.dispatch(loadActivities()); | ||
| this.store.dispatch(loadUsers()); | ||
| this.store.dispatch(loadStatuses()); | ||
| this.store.dispatch(initApp()); |
tomalaforge
reviewed
Nov 25, 2022
| selectStatusState, | ||
| (state) => state.teachersMap.get(name) ?? [] | ||
| selectTeachersMap, | ||
| (teachersMap) => teachersMap.get(name) ?? [] |
Owner
There was a problem hiding this comment.
you don't need the last two selectors. You should create a viewModel with construct your final object that you will use in your view
tomalaforge
reviewed
Nov 25, 2022
| } | ||
| }, []); | ||
| } | ||
| return []; |
Owner
There was a problem hiding this comment.
that 's the way to do it, nice
Owner
|
Thanks for submitting your answer. |
AlexxxTr
added a commit
to AlexxxTr/angular-challenges
that referenced
this pull request
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for challenge submission