Refactor Pretty control sequence escaping#3483
Open
LHolten wants to merge 6 commits intotokio-rs:mainfrom
Open
Refactor Pretty control sequence escaping#3483LHolten wants to merge 6 commits intotokio-rs:mainfrom
Pretty control sequence escaping#3483LHolten wants to merge 6 commits intotokio-rs:mainfrom
Conversation
Author
|
I just realized that this doesn't help with the ansi colour codes at all, because those are normal characters after the escape character. I will update this PR with a better implementation to skip the colour codes. |
Pretty control sequence escapingPretty control sequence escaping
Pretty control sequence escapingPretty control sequence escaping
Author
Fixed and added a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
Prettyformatter was applying escaping to control characters, but only for themessagefield and errors.Another issue is that the escaped control characters often make the
messagefield unreadable because of colour codes #3369.Solution
First, this PR fixes the
Prettyformatter to apply escaping consistently to all fields (theDefaultFieldsformatter seems to also skip escaping some field, but I did not want to fix it).It also changes the escaping on the
messagefield specifically to remove CSI codes entirely instead of just escaping them. While this doesn't fix #3369 entirely, it makes the problem a bit less bad, because now you can at least read the message.This solution does not make any changes to the public API, because I do not know what the best solution is to solving the trusted control characters problem.