Use unconnected socket#1758
Merged
hawkw merged 1 commit intotokio-rs:masterfrom Dec 16, 2021
swsnr:1745-unconnected-socket
Merged
Use unconnected socket#1758hawkw merged 1 commit intotokio-rs:masterfrom swsnr:1745-unconnected-socket
hawkw merged 1 commit intotokio-rs:masterfrom
swsnr:1745-unconnected-socket
Conversation
Contributor
Author
|
/cc @Ralith |
swsnr
commented
Nov 30, 2021
swsnr
commented
Dec 5, 2021
swsnr
commented
Dec 5, 2021
Contributor
Author
Ralith
reviewed
Dec 5, 2021
Lets journald subscribers survive a journald restart. Closes #1745
Ralith
approved these changes
Dec 6, 2021
Contributor
Author
|
@hawkw Is anything still blocking this pull request? 😊 |
Member
hawkw
pushed a commit
that referenced
this pull request
Dec 19, 2021
Lets journald subscribers survive a journald restart. Closes #1745 ## Motivation Currently the journald subscriber immediately connects to the journald socket. As such I understand it'd not survive a full restart of journald. ## Solution Do not connect the client socket immediately; instead pass the socket pathname every time we send a message. This is also what upstream does.
hawkw
pushed a commit
that referenced
this pull request
Dec 19, 2021
Lets journald subscribers survive a journald restart. Closes #1745 ## Motivation Currently the journald subscriber immediately connects to the journald socket. As such I understand it'd not survive a full restart of journald. ## Solution Do not connect the client socket immediately; instead pass the socket pathname every time we send a message. This is also what upstream does.
hawkw
pushed a commit
that referenced
this pull request
Dec 20, 2021
Lets journald subscribers survive a journald restart. Closes #1745 ## Motivation Currently the journald subscriber immediately connects to the journald socket. As such I understand it'd not survive a full restart of journald. ## Solution Do not connect the client socket immediately; instead pass the socket pathname every time we send a message. This is also what upstream does.
hawkw
added a commit
that referenced
this pull request
Dec 30, 2021
# 0.2.1 (December 29, 2021) This release improves how `tracing-journald` communicates with `journald`, including the handling of large payloads. ### Added - Use an unconnected socket, so that logging can resume after a `journald` restart ([#1758]) ### Fixed - Fixed string values being written using `fmt::Debug` ([#1714]) - Fixed `EMSGSIZE` when log entries exceed a certain size ([#1744]) A huge thank-you to new contributor @lunaryorn, for contributing all of the changes in this release! [#1714]: #1714 [#1744]: #1744 [#1758]: #1758
hawkw
added a commit
that referenced
this pull request
Dec 30, 2021
# 0.2.1 (December 29, 2021) This release improves how `tracing-journald` communicates with `journald`, including the handling of large payloads. ### Added - Use an unconnected socket, so that logging can resume after a `journald` restart ([#1758]) ### Fixed - Fixed string values being written using `fmt::Debug` ([#1714]) - Fixed `EMSGSIZE` when log entries exceed a certain size ([#1744]) A huge thank-you to new contributor @lunaryorn, for contributing all of the changes in this release! [#1714]: #1714 [#1744]: #1744 [#1758]: #1758
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.2.1 (December 29, 2021) This release improves how `tracing-journald` communicates with `journald`, including the handling of large payloads. ### Added - Use an unconnected socket, so that logging can resume after a `journald` restart ([tokio-rs#1758]) ### Fixed - Fixed string values being written using `fmt::Debug` ([tokio-rs#1714]) - Fixed `EMSGSIZE` when log entries exceed a certain size ([tokio-rs#1744]) A huge thank-you to new contributor @lunaryorn, for contributing all of the changes in this release! [tokio-rs#1714]: tokio-rs#1714 [tokio-rs#1744]: tokio-rs#1744 [tokio-rs#1758]: tokio-rs#1758
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets journald subscribers survive a journald restart.
Closes #1745
Motivation
Currently the journald subscriber immediately connects to the journald socket. As such I understand it'd not survive a full restart of journald.
Solution
Do not connect the client socket immediately; instead pass the socket pathname every time we send a message. This is also what upstream does.