fs: handle EINTR in fs::write for io-uring#7786
Merged
ADD-SP merged 1 commit intotokio-rs:masterfrom Dec 24, 2025
Merged
Conversation
2a6348f to
2f5f80a
Compare
martin-g
reviewed
Dec 23, 2025
Contributor
Author
|
I have no idea how my small patch in some io-uring code broke FreeBSD 64 bit (but not FreeBSD 32 bit somehow); either spurious or someone else broke this or somehow not doing |
Contributor
|
CI can fail spuriously sometimes. |
martin-g
approved these changes
Dec 23, 2025
ADD-SP
reviewed
Dec 24, 2025
Member
ADD-SP
left a comment
There was a problem hiding this comment.
Overall looks good to me, just a minor style comment.
EINTR in fs::write for io-uring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal change fixing a todo in io-uring code