Skip to content

fs: handle EINTR in fs::write for io-uring#7786

Merged
ADD-SP merged 1 commit intotokio-rs:masterfrom
vrtgs:master
Dec 24, 2025
Merged

fs: handle EINTR in fs::write for io-uring#7786
ADD-SP merged 1 commit intotokio-rs:masterfrom
vrtgs:master

Conversation

@vrtgs
Copy link
Contributor

@vrtgs vrtgs commented Dec 23, 2025

internal change fixing a todo in io-uring code

@vrtgs vrtgs force-pushed the master branch 2 times, most recently from 2a6348f to 2f5f80a Compare December 23, 2025 01:04
@vrtgs
Copy link
Contributor Author

vrtgs commented Dec 23, 2025

I have no idea how my small patch in some io-uring code broke FreeBSD 64 bit (but not FreeBSD 32 bit somehow); either spurious or someone else broke this or somehow not doing err.raw_os_error() == Some(libc::EINTR) broke it

@Darksonn
Copy link
Contributor

CI can fail spuriously sometimes.

@ADD-SP ADD-SP added A-tokio Area: The main tokio crate M-fs Module: tokio/fs labels Dec 24, 2025
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just a minor style comment.

@ADD-SP ADD-SP added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Dec 24, 2025
@vrtgs vrtgs requested a review from ADD-SP December 24, 2025 14:57
@ADD-SP ADD-SP changed the title handle EINT in tokio::fs::write for io-uring fs: handle EINTR in fs::write for io-uring Dec 24, 2025
@ADD-SP ADD-SP removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Dec 24, 2025
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ADD-SP ADD-SP merged commit d666068 into tokio-rs:master Dec 24, 2025
152 of 161 checks passed
@martin-g martin-g added the T-io-uring Topic: Linux io_uring label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio Area: The main tokio crate M-fs Module: tokio/fs T-io-uring Topic: Linux io_uring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants