task: clarify the behavior of several spawn_local methods#7669
Merged
ADD-SP merged 7 commits intotokio-rs:masterfrom Oct 12, 2025
Merged
task: clarify the behavior of several spawn_local methods#7669ADD-SP merged 7 commits intotokio-rs:masterfrom
spawn_local methods#7669ADD-SP merged 7 commits intotokio-rs:masterfrom
Conversation
ADD-SP
added
A-tokio-util
Darksonn
reviewed
Oct 11, 2025
tokio-util/src/task/join_map.rs
Outdated
Comment on lines
347
to
349
|
|
||
| /// Spawn the provided task on the current [`LocalSet`] and store it in this | ||
| /// Spawn the provided task on the current [`LocalSet`] or [`LocalRuntime`] and store it in this | ||
| /// `JoinMap` with the provided key. |
Member
There was a problem hiding this comment.
Please try to keep the line length consistent with the rest of the file.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review, I fixed the formatting, let me know if now it makes sense to you
Member
|
tokio/tokio-util/src/task/join_queue.rs Line 106 in e7e02fc Could you also update the docs of |
Contributor
Author
Sure @ADD-SP, added also for |
ADD-SP
changed the title
spawn_local methodsspawn_local methods
ADD-SP
changed the title
spawn_local methodsspawn_local methods
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7561