net: implement AsRef<Self> for TcpStream and UnixStream#7573
Merged
Darksonn merged 4 commits intotokio-rs:masterfrom Sep 4, 2025
Merged
net: implement AsRef<Self> for TcpStream and UnixStream#7573Darksonn merged 4 commits intotokio-rs:masterfrom
AsRef<Self> for TcpStream and UnixStream#7573Darksonn merged 4 commits intotokio-rs:masterfrom
Conversation
Darksonn
reviewed
Sep 4, 2025
Member
Darksonn
left a comment
There was a problem hiding this comment.
Hmm. Initially I was going to say no to this, but it seems that the stdlib documentation says that libraries should add this kind of impl for AsRef, so I'm going to accept it.
However, please add the AsRef impl to other types with owned read/write halves such as UnixStream too.
Contributor
Author
|
Thanks for your review, I've made the requested changes :) |
AsRef<Self> for TcpStream and UnixStream
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I'm writing a wrapper that I want to work for
OwnedReadHalfandTcpStream.OwnedReadHalf: AsRef<TcpStream>already, so this helps.Solution
TcpStream: AsRef<Self>