build: Grab binary path from cargo - #1429
Merged
Merged
Conversation
caspermeijn
enabled auto-merge
May 29, 2026 12:06
The conformance test needs the path to a generated binary. This was calculated based on the path of the test binary. This assumption fails when the build dir is changed with `CARGO_BUILD_BUILD_DIR`. Take the path from the environment as Cargo will store it there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conformance test needs the path to a generated binary. This was calculated based on the path of the test binary. This assumption fails when the build dir is changed with
CARGO_BUILD_BUILD_DIR. Take the path from the environment as Cargo will store it there.