build(protobuf): Use same protoc from same repo as .proto-files - #1136
Merged
Conversation
caspermeijn
marked this pull request as draft
August 23, 2024 09:07
caspermeijn
force-pushed
the
protoc_from_repo
branch
from
August 23, 2024 09:26
b27476d to
a87ef17
Compare
caspermeijn
force-pushed
the
protoc_from_repo
branch
from
September 1, 2024 12:11
a87ef17 to
6b1a69e
Compare
Crate `protobuf` compiles some .proto-files from the checked out repo in `third_party/protobuf`. Those files can use newest features from `protoc`. Therefore during development the `protoc` in `PATH` must be the same version or newer than in `third_party/protobuf`. The crate already builds a `protoc` compiler from the checked out repo to be used in conformance executable. Use that specific `protoc` for compiling the .proto-files in the crate. This doesn't influence the `protoc` used in crate `tests` nor published crates.
caspermeijn
force-pushed
the
protoc_from_repo
branch
from
September 4, 2024 11:11
6b1a69e to
ff26b23
Compare
caspermeijn
marked this pull request as ready for review
September 4, 2024 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crate
protobufcompiles some .proto-files from the checked out repo inthird_party/protobuf. Those files can use newest features fromprotoc. Therefore during development theprotocinPATHmust be the same version or newer than inthird_party/protobuf.The crate already builds a
protoccompiler from the checked out repo to be used in conformance executable. Use that specificprotocfor compiling the .proto-files in the crate.This doesn't influence the
protocused in cratetestsnor published crates.