Update windows-sys and dev-dependencies#1901
Conversation
|
Does anyone have an idea of what is causing the sanitizer error? A change in nightly maybe? The error: It looks like the flag isn't set properly when compiling doc-tests. |
|
The error is rust-lang/rust#146465. |
|
I have added a commit to pin the nightly version until the issue is resolved. |
33f467f to
09ae172
Compare
|
I updated the PR to allow both 0.60 and 0.61 versions for
|
|
Tokio is updating their MSRV to 1.71: tokio-rs/tokio#7658. Does it make sense to do the same for Mio now? |
|
Should I keep both versions (0.60 and 0.61) available to keep MSRV or do like |
There was a problem hiding this comment.
We've discussed this and decided to accept the bump in MSRV to 1.71, to unlock the update of window-sys. This does mean a lot of changes are needed:
- Bump to 1.1.0
- rust-version & MSRV to 1.71
- windows-sys -> 0.61.
Are you willing to make these changes @a1phyr ? Otherwise I can do them.
|
I've done the MSRV and dependencies part, and if you don't mind I prefer letting you do the release stuff. |
windows-systo 0.61 (Requires MSRV 1.71)env_loggerto 0.11 andrandto 0.9It would be nice to move from the old
wasiversion to the newwasip1crate but this requires MSRV 1.82, so I'm not sure this is acceptable.