Skip to content

Update windows-sys and dev-dependencies#1901

Merged
Thomasdezeeuw merged 2 commits intotokio-rs:masterfrom
a1phyr:update_deps
Oct 15, 2025
Merged

Update windows-sys and dev-dependencies#1901
Thomasdezeeuw merged 2 commits intotokio-rs:masterfrom
a1phyr:update_deps

Conversation

@a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Sep 10, 2025

  • windows-sys to 0.61 (Requires MSRV 1.71)
  • dev-dependencies: env_logger to 0.11 and rand to 0.9

It would be nice to move from the old wasi version to the new wasip1 crate but this requires MSRV 1.82, so I'm not sure this is acceptable.

@a1phyr
Copy link
Contributor Author

a1phyr commented Sep 12, 2025

Does anyone have an idea of what is causing the sanitizer error? A change in nightly maybe?

The error:

   Doc-tests mio
error: mixing `-Zsanitizer` will cause an ABI mismatch in crate `mio`
  |
  = help: the `-Zsanitizer` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely
  = note: unset `-Zsanitizer` in this crate is incompatible with `-Zsanitizer=thread` in dependency `std`
  = help: set `-Zsanitizer=thread` in this crate or unset `-Zsanitizer` in `std`
  = help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=sanitizer` to silence this error

It looks like the flag isn't set properly when compiling doc-tests.

@Darksonn
Copy link
Member

The error is rust-lang/rust#146465.

@a1phyr
Copy link
Contributor Author

a1phyr commented Sep 23, 2025

I have added a commit to pin the nightly version until the issue is resolved.

@a1phyr a1phyr force-pushed the update_deps branch 2 times, most recently from 33f467f to 09ae172 Compare September 25, 2025 18:45
@a1phyr
Copy link
Contributor Author

a1phyr commented Sep 25, 2025

I updated the PR to allow both 0.60 and 0.61 versions for windows-sys, so the last version can be used while not breaking MSRV.

env_logger was only updated to 0.10.

@atouchet
Copy link
Contributor

atouchet commented Oct 8, 2025

Tokio is updating their MSRV to 1.71: tokio-rs/tokio#7658. Does it make sense to do the same for Mio now?

@a1phyr
Copy link
Contributor Author

a1phyr commented Oct 15, 2025

Should I keep both versions (0.60 and 0.61) available to keep MSRV or do like tokio and update the MSRV?

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed this and decided to accept the bump in MSRV to 1.71, to unlock the update of window-sys. This does mean a lot of changes are needed:

  • Bump to 1.1.0
  • rust-version & MSRV to 1.71
  • windows-sys -> 0.61.

Are you willing to make these changes @a1phyr ? Otherwise I can do them.

@a1phyr
Copy link
Contributor Author

a1phyr commented Oct 15, 2025

I've done the MSRV and dependencies part, and if you don't mind I prefer letting you do the release stuff.

@a1phyr a1phyr requested a review from Thomasdezeeuw October 15, 2025 13:12
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a1phyr !

@Thomasdezeeuw Thomasdezeeuw merged commit 3c7ed97 into tokio-rs:master Oct 15, 2025
53 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants