Improve error messages with #[diagnostic::do_not_recommend]#3588
Merged
Improve error messages with #[diagnostic::do_not_recommend]#3588
Conversation
… to make other impls show up in errors instead.
jplatte
force-pushed
the
jplatte/do-not-recommend
branch
2 times, most recently
from
3404a63 to
5ce2f0c
Compare
Turbo87
approved these changes
Dec 20, 2025
Collaborator
Turbo87
left a comment
Turbo87
left a comment
There was a problem hiding this comment.
seems reasonable, I guess 👍
jplatte
added a commit
that referenced
this pull request
Dec 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See trybuild test output changes :)