Skip to content

fix(dash): fix visibility of senior email forwarding header #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2025

Conversation

makors
Copy link
Contributor

@makors makors commented Jun 5, 2025

Proposed changes

  • Only have the announcement header for senior email forwarding show on the first page of the dashboard announcements

Brief description of rationale

The senior email forwarding announcement currently shows on pages it shouldn't, like the club announcements page (see image below). This fixes that by only showing it on the main dashboard page.

image

@coveralls
Copy link

coveralls commented Jun 6, 2025

Coverage Status

coverage: 79.398%. remained the same
when pulling 7677bab on makors:senior-email-header
into 0d8ccc3 on tjcsl:dev.

@makors makors marked this pull request as ready for review June 6, 2025 00:13
@makors makors requested a review from a team as a code owner June 6, 2025 00:13
@aarushtools aarushtools reopened this Aug 24, 2025
@aarushtools aarushtools merged commit 941b791 into tjcsl:dev Aug 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants