Skip to content

Conversation

eschnett
Copy link
Contributor

Revise's list of stdlibs is incomplete. This is currently a blocker for JuliaLang/julia#58731: This PR updates LibGit2_jll to a new version, and this version has both PCRE2_jll and Zlib_jll as dependencies. Revise does not know about these two stdlibs, and this makes Julia's CI self tests fail.

This is a pared-down version of #929. That other PR still may or may not make sense.

After this PR is merged we will need to update the version of Revise used by Julia's CI tests.

@eschnett
Copy link
Contributor Author

The build error on Windows looks like a spurious problem. Can you restart that build?

@eschnett
Copy link
Contributor Author

The error on Windows with Julia 1.12-beta4 seems real. It looks as if this was a failure during garbage collection.

@eschnett eschnett marked this pull request as draft June 17, 2025 12:09
@eschnett
Copy link
Contributor Author

The current build failures are not caused by this PR. I changed the PR to make no meaningful change (it only introduces a comment) and yet both one of the CI Windows builds and the CI documentation builds are failing. It might be that there is some incompatibility between Julia 1.12-beta4 and Revise on Windows.

How do you want to address this? I do not have a Windows machine to track down the problem (and it's independent of this PR). Would it be possible to merge this PR even while one of the Windows builds is failing? Or do you plan to fix this first?

@pfitzseb
Copy link
Collaborator

Seems like a good idea to merge this anyways and debug the Windows failure elsewhere.

@eschnett eschnett marked this pull request as ready for review June 18, 2025 15:24
@pfitzseb pfitzseb merged commit a46d53b into timholy:master Jun 19, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants