fix: use vectorizer id for pg_try_advisory_xact_lock instead of queue… #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
JamesGuthrie
approved these changes
Aug 20, 2025
smoya
approved these changes
Aug 20, 2025
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
jgpruitt
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… oid
We were using the queue table's oid as the first key to pg_try_advisory_xact_lock when fetching work from the queue. Unfortunately, oids are 64-bit, and the two-key version of pg_try_advisory_xact_lock takes two 32-bit integers. This fails if the oid gets sufficiently large.
Each vectorizer has exactly one queue table. So, we can substitute the vectorizer's (32-bit) integer ID for the queue table's OID and still have the same uniqueness guarantee.