Skip to content

Drop obsolete go.uber.org/automaxprocs #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Drop obsolete go.uber.org/automaxprocs #632

merged 1 commit into from
Aug 15, 2025

Conversation

timebertt
Copy link
Owner

What this PR does / why we need it:

With #625, automaxprocs should no longer be needed, see https://tip.golang.org/doc/go1.25#container-aware-gomaxprocs:

On Linux, the runtime considers the CPU bandwidth limit of the cgroup containing the process, if any. If the CPU bandwidth limit is lower than the number of logical CPUs available, GOMAXPROCS will default to the lower limit. In container runtime systems like Kubernetes, cgroup CPU bandwidth limits generally correspond to the “CPU limit” option. The Go runtime does not consider the “CPU requests” option.

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:

@timebertt timebertt added the cleanup Code cleanup label Aug 15, 2025
@timebertt timebertt enabled auto-merge (squash) August 15, 2025 20:34
@timebertt timebertt moved this from Backlog to In progress in kubernetes-controller-sharding Aug 15, 2025
@timebertt timebertt merged commit a6552d8 into main Aug 15, 2025
4 checks passed
@timebertt timebertt deleted the drop-automaxprocs branch August 15, 2025 20:40
@github-project-automation github-project-automation bot moved this from In progress to Done in kubernetes-controller-sharding Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup
Projects
Development

Successfully merging this pull request may close these issues.

1 participant