txnkv: fix SetCommitWaitUntilTSOTimeout does not work in causal consistency#1847
Conversation
📝 WalkthroughWalkthroughThis PR fixes a bug where SetCommitWaitUntilTSO didn't work when causal consistency was enabled. The fix modifies the timestamp fetch condition in the two-phase commit flow to also trigger when commitWaitUntilTSO is configured, independent of linearizability requirements. Test coverage is expanded to verify the fix. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
…sistency Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
26bfb15 to
7c196ba
Compare
|
@tiancaiamao: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix #1846
Summary by CodeRabbit
Release Notes
Tests
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.