Skip to content

region_request: Print unretryable region error properly#1771

Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
MyonKeminta:m/print-unretryable-region-error-properly
Nov 28, 2025
Merged

region_request: Print unretryable region error properly#1771
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
MyonKeminta:m/print-unretryable-region-error-properly

Conversation

@MyonKeminta
Copy link
Copy Markdown
Contributor

@MyonKeminta MyonKeminta commented Oct 20, 2025

Otherwise it will produce this kind of logs:

[2025/10/19 19:29:08.283 +00:00] [INFO] [region_request.go:1534] ["met unretriable region error: *errorpb.Error"][.....

Which has the actual contant of the error being missing

@MyonKeminta
region_request: Print unretryable region error properly
738f41b 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 20, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Oct 30, 2025

@tiancaiamao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 24, 2025

@tiancaiamao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ekexium ekexium requested a review from cfzjywxk November 28, 2025 07:47
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2025
@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 28, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 28, 2025

@tiancaiamao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 28, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-20 07:32:03.608619898 +0000 UTC m=+684229.685872459: ☑️ agreed by ekexium.
  • 2025-11-28 07:56:34.247246754 +0000 UTC m=+862357.896441211: ☑️ agreed by cfzjywxk.
  • 2025-11-28 07:56:43.560324433 +0000 UTC m=+862367.209518890: ✖️🔁 reset by cfzjywxk.
  • 2025-11-28 08:29:28.398314974 +0000 UTC m=+864332.047509421: ☑️ agreed by ekexium.
  • 2025-11-28 08:44:49.750325151 +0000 UTC m=+865253.399519608: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit f9460d4 into tikv:master Nov 28, 2025
11 checks passed
@MyonKeminta MyonKeminta deleted the m/print-unretryable-region-error-properly branch November 28, 2025 08:50
joechenrh pushed a commit to joechenrh/client-go that referenced this pull request Jan 21, 2026
@MyonKeminta @ekexium
@cfzjywxk @joechenrh
region_request: Print unretryable region error properly (tikv#1771)
043158f 
 

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
wshwsh12 pushed a commit to wshwsh12/client-go that referenced this pull request Feb 10, 2026
@MyonKeminta @ekexium
@cfzjywxk @wshwsh12
region_request: Print unretryable region error properly (tikv#1771)
e767db7 
 

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
wshwsh12 pushed a commit to wshwsh12/client-go that referenced this pull request Feb 10, 2026
@MyonKeminta @ekexium
@cfzjywxk @wshwsh12
region_request: Print unretryable region error properly (tikv#1771)
ee18aba 
Signed-off-by: MyonKeminta <9948422+MyonKeminta@users.noreply.github.com>

Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: cfzjywxk <lsswxrxr@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@ekexium ekexium ekexium approved these changes

+1 more reviewer

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-integration-tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MyonKeminta @tiancaiamao @cfzjywxk @ekexium