Skip to content

Duplicated names #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 22, 2020
Merged

Duplicated names #924

merged 6 commits into from
Apr 22, 2020

Conversation

mgirlich
Copy link
Contributor

@mgirlich mgirlich commented Apr 3, 2020

Fixes #834

@hadley
Copy link
Member

hadley commented Apr 21, 2020

Looks good — Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@hadley
Copy link
Member

hadley commented Apr 22, 2020

Actually let me finish this off since I created a merge conflict.

@hadley hadley merged commit b34f662 into tidyverse:master Apr 22, 2020
@hadley
Copy link
Member

hadley commented Apr 22, 2020

Thanks for the code!

@mgirlich mgirlich deleted the duplicated-names branch January 28, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hoist doesn't handle duplicate names well
2 participants
@mgirlich @hadley