Add error_call and ... to packing/chopping utilities
#1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
force-pushed
the
feature/dots-and-error-calls
branch
from
9b65ffb to
fe0ae9e
Compare
DavisVaughan
commented
Jan 9, 2023
| @@ -125,7 +125,6 @@ nest.data.frame <- function(.data, ..., .names_sep = NULL, .key = deprecated()) | |||
|
|
|||
| #' @export | |||
| nest.tbl_df <- function(.data, ..., .names_sep = NULL, .key = deprecated()) { | |||
| check_string(.names_sep, allow_null = TRUE) | |||
There was a problem hiding this comment.
Managed by pack() now
hadley
approved these changes
Jan 10, 2023
This ensures all 6 functions in the nest/pack/unchop family disallow renaming
DavisVaughan
force-pushed
the
feature/dots-and-error-calls
branch
from
47fb604 to
52239e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1447
Closes #1446
error_callto the "backend" functions ofpack(),unpack(),chop(), andunchop()...tounpack(),unchop(), andchop()nest(),unnest(),pack(),unpack(),chop(), andunchop()"8c16af6a-b91e-47df-9707-5270b389ec14"One change in revdeps from tidypaleo which was accidentally passing a named tidyselection through to
unnest(). I'm happy to fix that one to get all 6 of these functions working consistently.