Ensure that pivoting a zero row data frame returns zero rows #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do this anyways later on before `vec_cbind()`ing, so it won't affect the output type. The original hack is incorrect in the zero row data frame case, because `nrow` should be `0L` here, and `rows` should have zero rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1252
Now that #1253 is merged, we can remove this slightly incorrect conditional code path for the zero column case (because it doesn't handle the zero row case right). But we still need to handle data.table's behavior with
dt[character()]returning a zero row data table (see #1073), so we just convertdatato a tibble early on to avoid this. We do this anyways eventually, so it doesn't affect any behavior.