Kafka Endpoint Improvement (Kafka 4.0+ Support)#778
Merged
tidwall merged 3 commits intotidwall:masterfrom Aug 27, 2025
Merged
Conversation
Update module dependencies to refresh transitive versions and remove unused indirect entries. - Bump github.com/IBM/sarama from v1.45.2 to v1.46.0 to pick up fixes and improvements in the Kafka client library.
Remove the hard-coded sarama client version (V0_10_0_0) which was previously required to address a backward-incompatibility. Sarama now derives the protocol version from the broker in recent releases, so forcing the old version causes version negotiation failures with modern Kafka brokers (e.g., Kafka 4.0+). This change re-enables sarama's automatic version selection to avoid breaking the connection and to improve compatibility with current broker releases. Also add a clarifying comment about the rationale.
i-branch-1
Owner
|
LGTM. Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka Endpoint improvements, dependency update, support for Kafka 4.0+
Please do not open a pull request without first filing an issue and/or discussing the feature directly with the project maintainer.
Describe your changes
Upgraded the Sarama package to the latest 1.46.0 that enables client API selection from the broker version. This handles backward compatibility and enables the correct Api version selection for 4.0+
Issue number and link
777